cloudfour / lighthouse-parade

A Node.js command line tool that crawls a domain and gathers lighthouse performance data for every page.
MIT License
358 stars 14 forks source link

Only the initial URL is crawled, and --max-crawl-depth is ignored #102

Closed eilidhhyslop-fmp closed 2 years ago

eilidhhyslop-fmp commented 2 years ago

When running lighthouse-parade using npx lighthouse-parade <url>, or npx lighthouse-parade <url> --max-crawl-depth 2, only the initial URL is reported on.

Curious if anyone else is seeing the same issue? We are both on Windows.

SamesJeabrook commented 2 years ago

Getting the same issue on a Mac. First tried on node v17.4.0 and was getting unsupported engine issues, but the whole site was crawled afterwards with errors on each URL crawled.

Tried several versions of node as specified by the unsupported engine message (^12.13.0 || ^14.0.0) and had the same issues @eilidhhyslop-fmp is experiencing, in that it would only give a successful report for the initial URL and that basically the crawl mechanism was unresponsive.

calebeby commented 2 years ago

Hi! Sorry for the delayed response, I'll take a look next week!

calebeby commented 2 years ago

@eilidhhyslop-fmp I will need to re-check on Windows since we don't regularly do Windows testing for this tool. It seems to be working fine on MacOS right now.

@SamesJeabrook I ran npx lighthouse-parade https://cloudfour.com and it appears to be crawling correctly and generating Lighthouse reports correctly. If you run that command, does it work for you? Can you provide a testing URL that doesn't work to help me reproduce the issue?

calebeby commented 2 years ago

It turns out I had been testing with 2.0.0, instead of the latest 2.0.1. 2.0.1 has this bug, 2.0.0 works correctly when --include-path-glob is not passed.

I've opened a PR to fix this: https://github.com/cloudfour/lighthouse-parade/pull/103

That should be merged soon, in the meantime you can pass --include-path-glob "/**" or use 2.0.0

SamesJeabrook commented 2 years ago

Amazing, thanks @calebeby!

calebeby commented 2 years ago

Published in v2.0.2

eilidhhyslop-fmp commented 2 years ago

Thanks @calebeby 😁 ⭐