search

cloudfour / lighthouse-parade

A Node.js command line tool that crawls a domain and gathers lighthouse performance data for every page.
MIT License
357 stars 14 forks source link

Don't reuse chrome instances #132

Closed calebeby closed 1 year ago

calebeby commented 1 year ago

Previously, it was set to reuse them to save time. Sometime between jan 1 and now, the chrome people changed something in chrome (or chrome devtools protocol) that makes it so that lighthouse can no longer reuse chrome instances. When I got back it just stopped working (I didn't change the lighthouse version but chrome probably auto-updated).

I opened an issue on lighthouse, but there does not seem to be an easy resolution (other than that their @next version works). I am reluctant to make lighthouse-parade dependent on the lighthouse prerelease version.

So, for now, each chrome instance is used once and then thrown away.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 708d276b6b1a7ce855aeab6975200b85bde44a82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

calebeby commented 1 year ago

Yeah, I think it would make sense to switch back to reusing chrome instances if lighthouse supports it in the future (/ finally releases the new version that they've been working on for years). I'll open an issue.