cloudfour / lighthouse-parade

A Node.js command line tool that crawls a domain and gathers lighthouse performance data for every page.
MIT License
358 stars 14 forks source link

[bugfix] force the initial path to be included in the crawling #99

Closed calebeby closed 2 years ago

calebeby commented 2 years ago

Closes #94

When I wrote the --help text I was mistaken about the actual behavior, I wrote it based on the behavior I wanted 🙈. Optimistic documentation!!

Now I implemented the behavior as I intended for it to work.

Testing:

git checkout bugfix-force-include-root-path
npm i
npm run build
npm link
lighthouse-parade https://something.com/blog --include-path-glob "/blog/**"
changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 8af280e66f7fe3da55a14ddf97c6b8c83a314299

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | lighthouse-parade | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

calebeby commented 2 years ago

This PR introduced a bug: https://github.com/cloudfour/lighthouse-parade/issues/102