cloudhead / http-console

simple, intuitive HTTP REPL — Speak HTTP like a local.
Apache License 2.0
1.35k stars 65 forks source link

printResponse: sys is not defined #8

Closed eugenebolshakov closed 14 years ago

eugenebolshakov commented 14 years ago

I'm getting a random error when doing multiple requests that result in non-json responses. There's no clear way to replicate it, but it looks like if I do several POST connections in a row with different POST data I'll get the error on 5th or 6th request:

http://www.google.ru:80/> POST
... 
HTTP/1.1 405 Method Not Allowed
Allow: GET, HEAD
Date: Sat, 12 Jun 2010 10:43:14 GMT
Content-Type: text/html; charset=UTF-8
Server: gws
Content-Length: 1391
X-Xss-Protection: 1; mode=block
Connection: close

ReferenceError: sys is not defined
    at [object Object].printResponse (/home/eugene/.node_libraries/.npm/http-console/0.3.0/package/lib/http-console.js:192:21)
    at /home/eugene/.node_libraries/.npm/http-console/0.3.0/package/lib/http-console.js:159:40
    at IncomingMessage. (/home/eugene/.node_libraries/.npm/http-console/0.3.0/package/lib/http-console.js:97:56)
    at IncomingMessage.emit (events:42:20)
    at HTTPParser.onMessageComplete (http:110:23)
    at Client.ondata (http:861:22)
    at IOWatcher.callback (net:502:31)
    at node.js:221:9

I've tried making the following change: eugenebolshakov/http-console@cb69a46ff5e23fe845bb34934b15156e8bdc89ae and it looks like the error doesn't occur anymore. However I can't really explain the reason :)

cloudhead commented 14 years ago

Very odd! will look into it.

cloudhead commented 14 years ago

Thinking about it now, I had this same problem previously. It might be node-related. I'm merging your changes for now.