search

cloudhead / neovim-fuzzy

Minimalistic fuzzy file finding for neovim
BSD 3-Clause "New" or "Revised" License
111 stars 17 forks source link

Fixed: Open selected files in splits with keybindings #39

Closed nannery closed 4 years ago

nannery commented 6 years ago

This is a continuation of PR #34 for Issue #15. I hadn't seen any movement so I added the fixes that @cloudhead wanted. If this isn't the place, let me know

jf commented 4 years ago

@cloudhead could you please review this? neovim-fuzzy is beautiful^. Now with the ability to open new files in splits, this would make this the perfect alternative to FZF!

^ I absolutely love the fact that special thought has been given even to the case when the list of files is initially open: When no input is given, fuzzy shows the alternate buffer (also known as '#'), followed by other open buffers, followed by all other files. Beautiful, and thank you!!

cloudhead commented 4 years ago

Thanks @jf !

I would be interested in merging this if it didn't bind any keys. I don't think this should be the job of the plugin. It should just provide fuzzy_split in this case, and let the user bind keys if they wish to.

jf commented 4 years ago

gotcha. Would setting g:fuzzy_bindkeys by default to 0 do it then? (I am not familiar with Vimscript, btw; this is just based on a cursory reading of https://github.com/cloudhead/neovim-fuzzy/pull/39/commits/9309cc4b23c7e11128cbc15ffa4561355d63e1c0)

cloudhead commented 4 years ago

I can give it a pass in the next few days, should be fairly quick.

jf commented 4 years ago

hi @cloudhead , did you get time to review this?

jf commented 4 years ago

@cloudhead just a ping again. Do you have any issues with this PR?

cloudhead commented 4 years ago

Sorry to keep you hanging, and thanks!