cloudhead / node-static

rfc 2616 compliant HTTP static-file server module, with built-in caching.
MIT License
2.17k stars 245 forks source link

Use less broken semver #198

Closed vkarpov15 closed 7 years ago

vkarpov15 commented 7 years ago

Thanks for all your work on this package but unfortunately v2 of the mime package breaks your code: https://www.npmjs.com/package/mime#version-2-notes

And:

$ node
> const semver = require('semver')
undefined
> semver.satisfies('2.0.1', '~1.2.9')
false
> semver.satisfies('2.0.1', '>=1.2.9')
true
> 
(To exit, press ^C again or type .exit)
> 
$ 

This is blocking prod deploys for me so please deploy a fix ASAP :+1: In general, I would strongly recommend switching to exactly pegged dependencies without the fancy ^ and ~ so you don't get issues like this.

cloudhead commented 7 years ago

Thanks, merged another one of these!

vkarpov15 commented 7 years ago

Thanks. Can you also change the use of >= in package.json? Otherwise I need to get a replacement static site lib, don't want to deal with this again.