search

cloudhead / rx

👾 Modern and minimalist pixel editor
https://discord.gg/xHggPjfsS9
GNU General Public License v3.0
3.07k stars 109 forks source link

F11 to quickly toggle fullscreen #123

Open wooster0 opened 2 years ago

wooster0 commented 2 years ago

I think this would be very convenient.

wooster0 commented 2 years ago

@xla could you elaborate on what's confusing you?

xla commented 2 years ago

Just wondering why F11 and not any other key or combination.

wooster0 commented 2 years ago

I just thought F11 is kind of the convention for fullscreen. It's the fullscreen key in a lot of games, browsers and other applications. But sure, maybe there could be more keys for that than just F11.

frogstair commented 1 year ago

I tried implementing the feature but unfortunately at the moment it cant be supported due to the limitations of the underlying glfw wrapper, however this pr allows you to start rx with the --fullscreen flag to start it in fullscreen

hendursaga commented 1 year ago

I just use my window manager, Sway in this case, to fullscreen at a press of a key..

frogstair commented 1 year ago

@hendursaga after a bit of digging I found how to implement the feature, now all we gotta do is wait for it to be merged some day