search

cloudhead / rx

👾 Modern and minimalist pixel editor
https://discord.gg/xHggPjfsS9
GNU General Public License v3.0
3.1k stars 109 forks source link

Platform-independent support for toggle-like key bindings #16

Closed fbbdev closed 5 years ago

fbbdev commented 5 years ago

This should work on any platform. I need it because I am stuck on winit, as glfw doesn't read correctly key combinations for me (e.g. <shift>+. on my layout should be a colon and enter command line, but under glfw only separate events for shift and dot are processed, so it just zooms in. Not sure why, maybe I should open an issue?)

cloudhead commented 5 years ago

Thanks, yeah that works :+1:

e.g. +. on my layout should be a colon and enter command line, but under glfw only separate events for shift and dot are processed, so it just zooms in. Not sure why, maybe I should open an issue?

As far as I know, glfw has the correct behavior there - but what we could look into is whether some of the key mappings should use the "char received" handler vs. the "key pressed" handler. Open an issue and we can discuss there.