cloudhead / rx

👾 Modern and minimalist pixel editor
https://discord.gg/xHggPjfsS9
GNU General Public License v3.0
3.09k stars 109 forks source link

If applied, this commit will stop some configs from panicking #53

Closed pop closed 4 years ago

pop commented 4 years ago

Some config options previously raised a panic of the following form:

thread 'main' panicked at 'fatal: no active view', src/session.rs:1293:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

The config commands in question include:

Fixes #51


TODO:

I'm not sure if these are worth doing, but I'm aware they're potential issues:

cloudhead commented 4 years ago

Would have modified blank(...) but it's use in Session::edit(...) put that above my ...

Ahhh, I forgot about this. Your approach makes more sense then. Just follow the recommendation about as_blank, and rename it to with_blank, as that makes a little more sense I think.

cloudhead commented 4 years ago

Thanks!