cloudhead / rx

👾 Modern and minimalist pixel editor
https://discord.gg/xHggPjfsS9
GNU General Public License v3.0
3.12k stars 109 forks source link

Does not compile on windows #6

Closed TailyFair closed 5 years ago

TailyFair commented 5 years ago

Compilation fails on Windows 10. Windows 10 Pro 1903 stable-x86_64-pc-windows-msvc (default) rustc 1.37.0 (eae3437df 2019-08-13)

   Compiling rx v0.1.0 (https://github.com/cloudhead/rx#af68f1f3)
error[E0433]: failed to resolve: could not find `BaseDirectories` in `xdg`
  --> C:\Users\User\.cargo\git\checkouts\rx-bc40bbadcd2c4422\af68f1f\src\lib.rs:79:26
   |
79 |     let base_dirs = xdg::BaseDirectories::with_prefix("rx")?;
   |                          ^^^^^^^^^^^^^^^ could not find `BaseDirectories` in `xdg`

error[E0412]: cannot find type `BaseDirectories` in module `xdg`
   --> C:\Users\User\.cargo\git\checkouts\rx-bc40bbadcd2c4422\af68f1f\src\session.rs:248:21
    |
248 |     base_dirs: xdg::BaseDirectories,
    |                     ^^^^^^^^^^^^^^^ not found in `xdg`

error[E0412]: cannot find type `BaseDirectories` in module `xdg`
   --> C:\Users\User\.cargo\git\checkouts\rx-bc40bbadcd2c4422\af68f1f\src\session.rs:331:25
    |
331 |         base_dirs: xdg::BaseDirectories,
    |                         ^^^^^^^^^^^^^^^ not found in `xdg`

error: aborting due to 3 previous errors

Some errors have detailed explanations: E0412, E0433.
For more information about an error, try `rustc --explain E0412`.
error: failed to compile `rx v0.1.0 (https://github.com/cloudhead/rx#af68f1f3)`, intermediate artifacts can be found at `C:\Users\User\AppData\Local\Temp\cargo-installGlInKN`

Similar issue found in https://github.com/sanpii/effitask/issues/8#issuecomment-401088191

cloudhead commented 5 years ago

Thanks, looks like I'll have to switch to the directories crate.

cloudhead commented 5 years ago

Hey I've switched to the directories crate - do you mind trying this out again with master? Note that you have to specify two features at the moment: --features winit,dx12 for example.

TailyFair commented 5 years ago

It compiles now :)

cloudhead commented 5 years ago

Cool, I'll close this - feel free to open another issue if something else doesn't work on windows.