ctrl-to-sample broken on windows

[guysv]

hi, love this software! the ctrl keyboard shortcut for sampler tool does not seem to respond on windows. The brush tool just keeps being active. Ill have some time to investigate it myself tomorrow, but for now I post about it here. tested with: rx 0.4.0 AND rx master

rustup show

Default host: x86_64-pc-windows-msvc
rustup home:  C:\Users\User\.rustup

installed toolchains
--------------------

stable-x86_64-pc-windows-msvc
nightly-x86_64-pc-windows-msvc (default)

active toolchain
----------------

nightly-x86_64-pc-windows-msvc (default)
rustc 1.43.0-nightly (442ae7f04 2020-02-06)

cmake (not sure why I list that but why not)

cmake version 3.16.4

[cloudhead]

Hey, could you load rx with the -v flag for verbose output, and paste the full output as well as when you press <ctrl>?

Can you also check if other shortcuts work?

Thanks

[guysv]

2020-02-11 19:35:19,942 DEBUG [rx] event: KeyboardInput(KeyboardInput { state: Pressed, key: Some(Control), modifiers: ModifiersState { shift: false, ctrl: true, alt: false, meta: false } })
2020-02-11 19:35:20,115 DEBUG [rx] event: MouseInput { state: Pressed, button: Left, modifiers: ModifiersState { shift: false, ctrl: true, alt: false, meta: false } }
2020-02-11 19:35:20,204 DEBUG [rx] event: MouseInput { state: Released, button: Left, modifiers: ModifiersState { shift: false, ctrl: true, alt: false, meta: false } }
2020-02-11 19:35:20,426 DEBUG [rx] event: KeyboardInput(KeyboardInput { state: Released, key: Some(Control), modifiers: ModifiersState { shift: false, ctrl: false, alt: false, meta: false } })
2020-02-11 19:35:20,426 DEBUG [rx::session] command: ToolPrev

For what I checked, everything else worked as expected.

[cloudhead]

Thanks, I have an idea how to fix this.

[cloudhead]

https://github.com/cloudhead/rx/commit/73f26c2b0b5c216caba8b049e478e5f02e7923f8 in master should fix it, can you give it a try?

[guysv]

yes! its working! thanks alot!