search

cloudhead / rx

👾 Modern and minimalist pixel editor
https://discord.gg/xHggPjfsS9
GNU General Public License v3.0
3.09k stars 109 forks source link

rx-drawn cursor is frozen and system cursor is invisible when over an inactive rx window #80

Closed ssokolow closed 4 years ago

ssokolow commented 4 years ago

On rx 0.4.0, if rx loses focus, all window updates will stop, which makes sense as a way to avoid waste... but the cursor drawn by rx also freezes.

It seems reasonable that, when rx loses window focus, it should temporarily undo "hide the system cursor while over this window so we can draw our own".

cloudhead commented 4 years ago

Ah interesting. Since I use a tiling window manager which focuses the window on hover, I haven't seen this happen. So the problem is that even though the rx window is inactive, it still hides the system cursor when it is above the window.

cloudhead commented 4 years ago

I've attempted a fix in the fix/issue-80 branch. Could you try it out?

ssokolow commented 4 years ago

Sure. I was too busy today, but I'll try to fit it in tomorrow.

ssokolow commented 4 years ago

It's not perfect, but it's a good enough fix for me.

(It has the same problem that causes accessibility issues for people with visual impairment with Snaps on Ubuntu... it ignores the user's system cursor theme, so my cursor changes from black with a white border to white with a black border when it crosses into an inactive fix/issue-80 window.)

cloudhead commented 4 years ago

Great. I'm unlikely to have a solution for the other problem that works cross-platform.

cloudhead commented 4 years ago

Fixed in de545c1