Frame cloning and sync editing

[fbbdev]

Full copying and pasting ability would be very useful ofc and I'm sure it's on the roadmap, but in the meantime two features would help a lot with the animation process:

• Frame cloning: add a new frame at the end (or even in the middle) with contents copied from another frame. Maybe a f/clone command with frame index?
• Synchronous editing: propagate edits in a single frame to one or more other frames.

Maybe I can add the features myself and open some PRs if you like the idea? Let me know. Thank you for building and sharing this project, looks really promising and it's pleasing to use.

[fbbdev]

Ah, I see there's a planned Multi mode for brushes, I suspect that's for multi-frame editing? In that case, is there something I could do to help with this feature?

[cloudhead]

Yeah, multi-brush is exactly what you're talking about. It's actually trivial to implement in rx. Frame cloning is also planned, I'll see how complicated it is.

[cloudhead]

Hey I pushed multi-brush to master, do you mind trying it out?

https://github.com/cloudhead/rx/commit/8d07970eb177841d00cfb360ddd55c44c28a9419

You have to run:

cargo install --git https://github.com/cloudhead/rx --force --locked --features vulkan,winit

To install it. Note the added winit feature.

Then hold <shift> while painting.

[fbbdev]

Thank you, I'll try it later today. I forgot to specify the tag yesterday when I installed so I already discovered the winit feature the hard way :D

On Tue, Aug 27, 2019, 23:22 Alexis Sellier notifications@github.com wrote:

Hey I pushed multi-brush to master, do you mind trying it out?

8d07970 https://github.com/cloudhead/rx/commit/8d07970eb177841d00cfb360ddd55c44c28a9419

You have to run:

cargo install --git https://github.com/cloudhead/rx --force --locked --features vulkan,winit

To install it. Note the added winit feature.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cloudhead/rx/issues/9?email_source=notifications&email_token=AAZCS7QY3GK5Q5XUC5WS66LQGWLJJA5CNFSM4IQGBRM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5JFCHQ#issuecomment-525488414, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZCS7QOVURU22F7KO2CDA3QGWLJJANCNFSM4IQGBRMQ .

On Tue, Aug 27, 2019, 23:22 Alexis Sellier notifications@github.com wrote:

Hey I pushed multi-brush to master, do you mind trying it out?

8d07970 https://github.com/cloudhead/rx/commit/8d07970eb177841d00cfb360ddd55c44c28a9419

You have to run:

cargo install --git https://github.com/cloudhead/rx --force --locked --features vulkan,winit

To install it. Note the added winit feature.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cloudhead/rx/issues/9?email_source=notifications&email_token=AAZCS7QY3GK5Q5XUC5WS66LQGWLJJA5CNFSM4IQGBRM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5JFCHQ#issuecomment-525488414, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZCS7QOVURU22F7KO2CDA3QGWLJJANCNFSM4IQGBRMQ .

[fbbdev]

Just tested it, works perfectly, thank you. However, it accidentally exposed a problem in input handling: when the command line is activated, the release binding for modifier keys is ignored. So when I type a colon (<shift>+. on my qwerty it layout) the brush goes to multi-mode permanently (until I hit <shift> again of course). See issue #11

[cloudhead]

Ah good catch, thanks for opening the issue!

[cloudhead]

Frame cloning is now implemented in master, via :f/clone. Let me know if you encounter issues!

[fbbdev]

Works great! Thank you.

Done with some help from multi-brush

Playing around with frame cloning :smile:

[fbbdev]

I think there could be a little bug though.. not sure if that was intended.

If you activate multibrush mode on frame 0, you get brushes for all frames. But if you activate on frame n, n > 0, you get brushes only for frames >= n. Also, if you start multi drawing on frame 0 and move to later frames, brushes will progressively disappear on the right and previous frames will not be drawn into.

[fbbdev]

Reading the code again I suspect that was the intended behavior.. however I find it a bit uncomfortable as I'd often like, when zoomed in, to multi-draw to the whole image without panning to the first frame. Also I often use the multi-brush as a reference to take measurements and reproduce features across different frames. The way it works now, I can only do that if I'm working in a frame that precedes the one I'm interested in. If I'm working in a later frame I have to count pixels instead.

Of course the current behavior is also very useful when animating.. not sure what would be better..

[cloudhead]

Works great! Thank you.

Great!

I think there could be a little bug though.. not sure if that was intended.

This is intended as it's quite helpful when animating, though I understand that it may get in the way. I'll think about it more.

[fbbdev]

Yeah you're right it's good for animation. Maybe it's too soon to reason about this.. maybe things will need to change a bit anyway after visual mode is fully implemented, and there could be new tools in the future like e.g. a measurement tool... In the meantime, the current functionality is already quite helpful for interesting work so not a major problem.

[cloudhead]

Yeah, maybe it can be a setting or something in the future - I think both use-cases are valid.