search

cloudhead / toto

the 10 second blog-engine for hackers
MIT License
1.49k stars 244 forks source link

Reference-style links broken in summaries #18

Open jerodsanto opened 14 years ago

jerodsanto commented 14 years ago

Links using the reference-style formatting...

This is [a link][1].
... rest of article
[1]:http://thelink.com

...are broken on summary views because the bottom of the article is truncated before being processed by Markdown.

cloudhead commented 14 years ago

Hmm interesting — this will probably require some extra preprocessing to get right.

nogweii commented 14 years ago

I've fixed this in my fork of dorothy (called mindtables) - evaryont@mindtables/0054653bfbba57589ee01fa762edfa37c10eb5d8 - but look at future commits, as that one is incomplete.

The general idea is to call Nokogiri on the parsed HTML, find the first element, and use that. It could be refined to only use the first <p> tag, but I like it this way.

nogweii commented 14 years ago

Sorry, that should link here: http://github.com/evaryont/mindtables/commit/0054653bfbba57589ee01fa762edfa37c10eb5d8

ixti commented 13 years ago

The problem is because markdown parser is called on "summary", not on whole article text, so when summary was cropped there are no bottom links definitions of course. The easiest workaround (which I found the best option for me) is do it like this:

Blalala in da mix Lorem ipsum dolor sit amet, consectetur adipiscing elit. Mauris facilisis justo eu nunc tristique nec pulvinar diam dapibus. Mauris sit amet nunc quis lorem egestas blandit vitae at erat. Morbi consequat molestie ligula ac euismod. Cras velit eros, tempor vitae facilisis vel, fringilla non ligula. Sed venenatis porttitor tellus, ut pharetra nunc vehicula non. Sed scelerisque sem in ante ultrices eget congue quam viverra. Praesent quis sem urna, vitae ornare justo. Donec tristique, erat id pellentesque consectetur, lorem mauris feugiat mi, et iaculis arcu felis a enim. Aliquam erat volutpat. Quisque imperdiet dapibus erat in tincidunt. Proin ut nulla diam, ut condimentum tortor.

~

The rest of article comes here ...

...

ixti commented 13 years ago

Might be resolved by #97

ixti commented 13 years ago

@cloudhead, please, take look on #97, if it's OK, then this issue can be closed.