search

cloudhead / toto

the 10 second blog-engine for hackers
MIT License
1.49k stars 245 forks source link

How do you access the request from a page? #42

Open ctwise opened 14 years ago

ctwise commented 14 years ago

Stupid question: how do you access the request from a page?

cloudhead commented 14 years ago

Do you mean the Rack environment object? It's not passed along to the page context.

You can access the path with @path, and the context object with @context.

Toto only lets through GET requests.

5v3n commented 14 years ago

Hi!

Thanks for that great work!

I'm thinking about moving my blog to toto, and started implementing a missing feature: tags. The feature is ready to roll, but it's based on the assumption that you are able to access the post parameter, e.g. /search?tag=hacks lists all articles tagged with 'hacks'.

Do I have to rewrite the rack routing, or am I overlooking an easy possibility to pass the prameter?

The correxponding rhtml file looks like this

Cheers

Sven

ctwise commented 14 years ago

Personally, I rewrote the Rack routing to pass in the request.

5v3n commented 14 years ago

Would you share the hack ;-)?

And Cloudhead: why did you decide not to pass the parameters to the erb binding? I can't see a reason for that, although I'm quite sure there is one...

cloudhead commented 14 years ago

Simplicity mainly, but seeing as it can be useful, and it was a small change, I just pushed the change, so you can access it with env or @env.

Let me know if it works, and if so I'll publish a new gem.

5v3n commented 14 years ago

I see your point - and I'm more than glad that you changed toto to pass env. I think it does not hurt the simplicity concept.

I'll test it tomorrow evening & tell you if it worked (although looking through the sources makes me quite positive that it will do so!).

UPDATE: couldn't wait & forked right away. had to adjust the implementation a little & added a test case. Looks right for me, but it's the first time I'm using riot unit tests - so I'm more than curious about your feedback:

http://github.com/5v3n/toto

BTW, I'm working on some toto related tools right now (tumblr export, tags & social bookmarks) & as soon they're in a presentable state I'll share them on github.

Cheers

Sven

cloudhead commented 14 years ago

Hey that's great, looking forward to those tools, and will fix the implementation.

EvanBurchard commented 13 years ago

I'm on 0.4.6. @env and env didn't make it into the gem yet, right?

Any plans to update it?

5v3n commented 13 years ago

Hi Evan,

we have a fork over here with access to 'env' that also has a prerelease gem on rubygems.org:

http://github.com/5v3n/toto

In addittion to that, you might find (karakuri)[http://github.com/5v3n/karakuri] quite handy. it adds some features to toto, i.e. tag support.

Cheers

Sven Kräuter | 5v3n

ixti commented 13 years ago

@cloudhead this isssue is also really old and ws solved before :))