cloudify-cosmo / cloudify-stage

Cloudify's New UI Framework
Apache License 2.0
40 stars 21 forks source link

Remove default host from server.listen to allow by default to listen on ipv6 and ipv4 #2646

Closed fstaniulamartus closed 3 months ago

fstaniulamartus commented 3 months ago

Description

From node documentation:

If host is omitted, the server will accept connections on the unspecified IPv6 address (::) when IPv6 is available, or the unspecified IPv4 address (0.0.0.0) otherwise.

In most operating systems, listening to the unspecified IPv6 address (::) may cause the net.Server to also listen on the unspecified IPv4 address (0.0.0.0).

We were setting localhost by default in the configuration, which on some systems where ipv6 was available, it would listen only on ipv6 interface. Omitting the default host, would in turn allow to listen by default on both interfaces if not specified in the configuration by user.

Screenshots / Videos

N/A

Checklist

Tests

N/A

Documentation

N/A