CFY-7301-limit-wagon-wheel-dependency-to-0.29.0

[nir0s]

Why was this limit introduced exactly?

[mcouthon]

Because wheel 0.30.0 dropped support for python 2.6 which we still need to support, and currently this was the simplest way to not break everything.

[nir0s]

But this solution is not generic to Wagon. Why not add an explicit dependency where Wagon is required to use wheel <=0.29 instead? Wagon can't make progress like this...

This explicitly makes Wagon incompatible with pip, etc..

[mxmrlv]

We could set the dependency to <=0.29. The idea was to make the dependency more consistent to other cloudify repos.

[funkyHat]

I agree with Nir here. wagon can work perfectly well with versions of wheel >=0.30, so this is the wrong place for the dependency. We only support 2.6 in the agent anyway, so the stricter dependency on wheel should be there.

If you're worried about introducing breakage then it should be possible to run wagon's test suite with wheel==0.29 in CI in addition to a newer/latest version.

On Mon, 2 Oct 2017 at 12:52 Maxim Orlov notifications@github.com wrote:

There's not wrong in setting the dependency to <=0.29. The idea was to make the dependency more consistent to other cloudify repos.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cloudify-cosmo/wagon/pull/110#issuecomment-333512348, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEAeXksUAEaac07K1XcOxG3TL-BQpMEks5soM5lgaJpZM4Plo30 .

--

-- Matt Wheeler http://funkyh.at

[mxmrlv]

Cloudify indeed needs python 2.6 only in the Agent. But Wagon states it supports python 2.6. So it either no longer supports python 2.6 (which is a valid option), or the wheel dependency should be that strict.

[nir0s]

You're right. So anyone who wants to use wagon on 2.6 would use a previous version of it and hardcode wheel. Wagon is as generic as wheel and pip in every way and should stay that way. I suggest reverting and adding to the Readme what's needed to support 2.6. Also, the Readme should state that as wheel 0.30+ no longer supports 2.6, wagon doesn't either.

On Mon, Oct 2, 2017, 23:39 Maxim Orlov notifications@github.com wrote:

Cloudify indeed needs python 2.6 only in the Agent. But Wagon states it supports python 2.6. So it either no longer supports python 2.6 (which is a valid option), or the wheel dependency should be that strict.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cloudify-cosmo/wagon/pull/110#issuecomment-333657948, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6QhOfE2qbDa53vS-YWXz-b7A55VKP_ks5soUntgaJpZM4Plo30 .

[nir0s]

@mxmrlv I submitted a PR to remove support for 2.6 and stated that anyone who needs to use 2.6 can use wagon 0.6.1.