cloudify-cosmo / wagon

Creates Wheel based archives to allow portable offline installation of Python packages and their dependencies
Apache License 2.0
114 stars 16 forks source link

Wagon fails to validate correct wagons #112

Closed mcouthon closed 6 years ago

mcouthon commented 7 years ago

This is actually probably 2 issues.

Issue 1

Steps to reproduce:

Issue 2

The steps to reproduce are the same, but here the cause is clear - after pip install _s change to -s, and so this fails. For example, here's a package on which create/validate will fail.

nir0s commented 7 years ago

@mcouthon well, that's actually a pip thing. Even when the package is named target_mock, the name when you run pip freeze will show target-mock.

What we can do, is one of two things:

  1. Validate both _ and -.
  2. Make sure the package name is always with dashes instead of underscores. I think this is a dangerous option (albeit more aesthetic), so I wouldn't go for it.
mcouthon commented 7 years ago

@nir0s Validating both seems sensible (and easy to implement).