search

cloudify-cosmo / wagon

Creates Wheel based archives to allow portable offline installation of Python packages and their dependencies
Apache License 2.0
114 stars 16 forks source link

Fix pip 10 compat #122

Closed nir0s closed 6 years ago

nir0s commented 6 years ago

This fixes #120 a compatibility problem with new versions of pip. In version 7.0.0 the --use-wheel flag was deprecated and it was removed (without acknowledgment in pip 10.0.0 i.e. it's not in the changelog).

nir0s commented 6 years ago

So.. the thing is, that pip isn't necessarily importable. We look for pip in different places to run as an executable.

EarthmanT commented 6 years ago

@nir0s Do we care about supporting <7.0.0? I'm only after version checking if we are supporting both uses. One alternative would be to actually check the version by executing the sys_exec path with version. Another would be try/except. Although the way these methods are organized that probably won't work here. Neither alternative is very good.

nir0s commented 6 years ago

I agree with @tehasdf. Additionally, Wagon directly depends on pip and wheel. IMHO this means that we should always simply support the latest versions of pip and wheel and document that people should use previous versions of Wagon (much like people use previous versions of pip and wheel) if needed.