search

cloudify-cosmo / wagon

Creates Wheel based archives to allow portable offline installation of Python packages and their dependencies
Apache License 2.0
114 stars 16 forks source link

Pass-Supported-Platform #143

Closed ahmadiesa-abu closed 2 years ago

ahmadiesa-abu commented 2 years ago

this PR address platform issue in case of new manylinux wheel naming convention [pep600 concatenate]

tehasdf commented 2 years ago

all in all the best idea is probably to just drop the 5.1-compat hack, because passing in the --supported-platform correctly means that plugins that need to be 5.1-compatible, can just be built with the override passed in

ahmadiesa-abu commented 2 years ago

this wont work because in the simple case of platform = manylinux_2_5_x86_64 (which is a pep600 alias for manylinux1_x86_64), the platform here ends up being linux_2_5_x86_64, which isn't valid (linux_x86_64 is)

I have added another snippet that handles these extreme cases

ahmadiesa-abu commented 2 years ago

all in all the best idea is probably to just drop the 5.1-compat hack, because passing in the --supported-platform correctly means that plugins that need to be 5.1-compatible, can just be built with the override passed in

I agree , that is why we fixed the create function to pass in supported-platform , but we also need to be able to handle it , if the user doesn't pass it also