Closed nir0s closed 7 years ago
Btw, this also renders appending the distribution and release to the wagon file name redundant.
@nir0s what if we don't convert linux_x86_64 to manylinux1 in this case. would it even work as expected?
@nirfuchs it will probably not work due to cross-distro glibc compat issues.
I supplied a repair
command (corresponding with auditwheel's repair command) which will repair all linux wheels to manylinux1, repack it, and update the metadata. This obviously requires the same environment required by auditwheel so it can't just be run anywhere.
@nir0s can you support passing args to auditwheel just as you do for pip? at minimum --plat
?
While we can declare that wagon only supports
manylinux1
if the wheels in it aremanylinux1
, I think we should add the ability to convertlinux_x64_86
tomanylinux1
to make the job a bit more comfortable for the user.Relevant links:
Since auditwheel requires Centos 5 (not older) to work (due to forward backward compat of glibc), we can verify that version of the distribution and only if it's Centos 5-, allow to run
wagon repair
which will recursively repair all wheels in the wagon and recreate the wagon.To test creating a
manylinux1
compat wheel, tryWDYT?