search

cloudify-incubator / cloudify-awssdk-plugin

Next generation of Cloudify AWS support.
Apache License 2.0
3 stars 6 forks source link

awssdk.cloudify_boto3.rds.resources.parameter_group.configure empty list fails validation #15

Closed EarthmanT closed 7 years ago

EarthmanT commented 7 years ago

The blueprint input was like this:

  ParameterGroup1:
    type: cloudify.nodes.aws.rds.ParameterGroup
    properties:
      resource_id: ParameterGroup1
      resource_config:
        kwargs:
          DBParameterGroupName: ParameterGroup1
          DBParameterGroupFamily: mysql5.6
          Description: Parameter Group 1
      client_config: *client_config
    relationships:
    - type: cloudify.relationships.aws.rds.parameter_group.connected_to
      target: parameter_1

Error is:

Task failed 'cloudify_boto3.rds.resources.parameter_group.configure' -> Parameter validation failed:
Missing required parameter in input: "Parameters"
Unknown parameter in input: "DBParameterGroupFamily", must be one of: DBParameterGroupName, Parameters
Unknown parameter in input: "Description", must be one of: DBParameterGroupName, Parameters

There are several solutions. I think that if resource_config is None, there is no reason here to run the configure operation.

01000101 commented 7 years ago

The code you referenced already checks if resource_config is None. This was a minor bug due to using either the resource_config from properties or lifecycle inputs, when it only should be pulling from lifecycle inputs.