search

cloudify-incubator / cloudify-helm-plugin

1 stars 1 forks source link

Meet 'NoneType' issue when install helm chart with empty entry of manifest #109

Open xho22 opened 2 weeks ago

xho22 commented 2 weeks ago

When I'm installing istio chart by helm plugin, it returns 'NoneType' error. After debug, the cause if manifest of helm_status contains empty entry. And will run into issue from below: https://github.com/cloudify-incubator/cloudify-helm-plugin/blob/f37c74d93c25f96ef2fb15debcc5bc5781cc84e1/helm_sdk/kubernetes.py#L125

Chart manifest:

#Result of command: helm status istio-base -n istio-system -o yaml
config:
  defaultRevision: default
info:
  deleted: ""
  description: Install complete
  first_deployed: "2024-08-29T03:18:10.688440447Z"
  last_deployed: "2024-08-29T03:18:10.688440447Z"
  notes: |
    Istio base successfully installed!

    To learn more about the release, try:
      $ helm status istio-base -n istio-system
      $ helm get all istio-base -n istio-system
  status: deployed
manifest: |
  ---
  # Source: base/templates/reader-serviceaccount.yaml
  # This service account aggregates reader permissions for the revisions in a given cluster
  # Should be used for remote secret creation.
  apiVersion: v1
  kind: ServiceAccount
  metadata:
    name: istio-reader-service-account
    namespace: istio-system
    labels:
      app: istio-reader
      release: istio-base
  ---
  # Source: base/templates/zzz_profile.yaml
  #  Flatten globals, if defined on a per-chart basis
  ---
  # Source: base/templates/default.yaml
  apiVersion: admissionregistration.k8s.io/v1
  kind: ValidatingWebhookConfiguration
  metadata:

Coverted image

The zzz_profile.yaml is empty. From my side, we don't suppose each key of manifest is present as some special chart design.

xho22 commented 2 weeks ago

I found it's caused by a comment: https://github.com/istio/istio/blob/1.22.4/manifests/zzz_profile.yaml#L39 I installed istio 1.22.3 and get the job done. However the issue is still should be fixed.