search

cloudify / sPDF

Create PDFs from Scala using plain old HTML and CSS. Uses wkhtmltopdf on the back-end which renders HTML using Webkit.
Other
199 stars 53 forks source link

wkhtmltoimage #41

Open AmazingDreams opened 7 years ago

AmazingDreams commented 7 years ago

I created an implementation for wkhtmltoimage, but was unable to test because wkhtmltopdf/image seems to be hanging in the tests.

Please review and comment about anything.

Basically I just copied and pasted the Pdf and PdfConfig classes and changed some strings here and there. I could simplify the implementation by simply extending those classes and only overriding findExecutable. But I can't test this, so this'll have to do for now.

AmazingDreams commented 7 years ago

I think this implementation is more or less final now. I tested it using publishLocal in another project and it all works. It's weird how the tests ran directly don't work (wkhtmltoX doesn't return) but the tests & code I run in that project work fine.