search

cloudigrade / frontigrade

GNU General Public License v3.0
4 stars 1 forks source link

237 authenticate login #21

Closed cdcabrera closed 6 years ago

cdcabrera commented 6 years ago

Story

updates Issue 237 relates PRs 308 324

jun-01-2018 02-34-45

How to test

Testing against Cloudigrade locally

Testing against Cloudigrade is possible, with the cavet that the API and configuration are constantly evolving. If you've gone through the Cloudigrade install process using Shiftigrade... review how to export and pull in the feature for local OpenShift testing

Quick dev test with mocks

Quick dev level tests can be performed on this branch and running the basic setup. After syncing the branch changes locally, and making sure you're on the correct branch...

  1. Make sure the Docker daemon is running, and you have Node installed

  2. Next, install the UI packages, then start it up.

      $ npm install
  $ npm start

    If this is your first time running the install it may take a few minutes since there's a Docker element associated with the local dev run. In addition the local run makes use of ports 3000 and 5000, anything running on those ports previously needs to be shut down.

  3. A browser tab should have opened automatically, if not open http://localhost:3000

    The mock server that's used for local development also renders basic API documentation. If there's a mismatch in API functionality, that can be found here... http://localhost:5000/docs/

codecov[bot] commented 6 years ago

Codecov Report

Merging #21 into master will increase coverage by 4.3%. The diff coverage is 86.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #21     +/-   ##
=========================================
+ Coverage    82.6%   86.91%   +4.3%     
=========================================
  Files           8       19     +11     
  Lines          46      214    +168     
  Branches        5       34     +29     
=========================================
+ Hits           38      186    +148     
- Misses          7       26     +19     
- Partials        1        2      +1
Impacted Files Coverage Δ
src/redux/reducers/index.js 100% <ø> (ø) :arrow_up:
src/redux/constants/index.js 100% <ø> (ø) :arrow_up:
src/components/router/routerConstants.js 100% <ø> (ø) :arrow_up:
src/services/accountServices.js 100% <100%> (ø)
src/services/reportServices.js 100% <100%> (ø)
...s/toastNotificationsList/toastNotificationsList.js 69.23% <100%> (+27.56%) :arrow_up:
src/redux/reducers/userReducers.js 100% <100%> (ø)
src/redux/actions/index.js 100% <100%> (ø)
src/redux/reducers/toastNotificationsReducers.js 100% <100%> (ø)
src/services/index.js 100% <100%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 155d2d4...b401504. Read the comment docs.

cdcabrera commented 6 years ago

Note: couple of non-blocking issues, could be iterated on