cloudigrade / frontigrade

GNU General Public License v3.0
4 stars 1 forks source link

update policy definitions with ec2:CopyImage and ec2:CreateTags #32

Closed infinitewarp closed 6 years ago

infinitewarp commented 6 years ago

It looks like my editor automatically stripped off the trailing whitespace from a few unrelated lines upon save. If this is a problem, please let me know and I will manually add them back.

codecov[bot] commented 6 years ago

Codecov Report

Merging #32 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   76.72%   76.72%           
=======================================
  Files          37       37           
  Lines         391      391           
  Branches       56       56           
=======================================
  Hits          300      300           
  Misses         82       82           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7821c4c...1085d39. Read the comment docs.

infinitewarp commented 6 years ago

Ahhhh, OK. I didn't realize the snap files were generated. Maybe they should be .gitignored?

Since the snap file is generated but checked in to the repo, I'll leave this change as-is since the net effect should be the same.

cdcabrera commented 6 years ago

Some quick testing, now I remember. @infinitewarp so it appears the spacing is needed within the snapshots. Looks like in order for the HTML snapshots to compare what template/component/view "was" vs "what is now" the comparison makes use of everything.

Easy fix on my part, have to re-check the snapshot in since the configuration.json file was updated. I'll continue looking at the config, maybe there's a way to stipulate that editors should ignore those files through the .editorconfig