cloudinary-community / cloudinary-examples

Easy Cloudinary integration examples for boosting web performance.
MIT License
88 stars 79 forks source link

Dependencies upgraded, sample images, app directory example added #143

Closed max-programming closed 7 months ago

max-programming commented 8 months ago

This PR makes the following changes

  1. Outdated dependencies upgraded to the latest version
  2. Display images from Cloudinary's sample directory
  3. An example added for app directory on the /app-demo path
  4. Rename file extensions from .js to .jsx for emmet to work on everyone's VS Code (without a setting change emmet does not work in .js files)
vercel[bot] commented 8 months ago

@max-programming is attempting to deploy a commit to the Cloudinary DevX Team on Vercel.

A member of the Team first needs to authorize it.

colbyfayock commented 7 months ago

hey @max-programming this looks good, pushed a prettier config preference

only other thought is if you wanted to pull the footer into a component like you did the header, since it's the same thing between Pages and App, but not a critical change

colbyfayock commented 7 months ago

i also updated the branch with main to fix the conflict

max-programming commented 7 months ago

hey @max-programming this looks good, pushed a prettier config preference

only other thought is if you wanted to pull the footer into a component like you did the header, since it's the same thing between Pages and App, but not a critical change

Thanks! Definitely makes sense to put footer into it's own component as well Done

colbyfayock commented 7 months ago

looks great @max-programming thank you!

colbyfayock commented 7 months ago

@all-contributors please add @max-programming for code

allcontributors[bot] commented 7 months ago

@colbyfayock

I've put up a pull request to add @max-programming! :tada: