cloudinary-community / cloudinary-util

https://cloudinary-util.vercel.app
MIT License
12 stars 19 forks source link

[Feature] Update `transformation` types for Cloudinary Video Player #202

Open colbyfayock opened 2 months ago

colbyfayock commented 2 months ago

Feature Request

Is your feature request related to a problem? Please describe.

We should update the types for Cloudinary Video Player for the available options:

https://github.com/cloudinary/js-url-gen/blob/master/src/types/types.ts#L431

This is the API that's used in the underlaying Video Player, via:

https://github.com/cloudinary/cloudinary-video-player/blob/edge/src/plugins/cloudinary/common.js#L55

Describe the solution you'd like

Should be able to, for the most part, copy in all of the types from the above int othe types/cloudinary-video-player.ts file

https://github.com/cloudinary-community/cloudinary-util/blob/main/packages/types/src/types/cloudinary-video-player.ts

nooras commented 1 month ago

Hey @colbyfayock i am interested in this task. Can u assign me ? shall i copy full block of LegacyITransforamtionOptions ? if yes! My code changes are ready let me know if its correct ?

Doubt: That particular block have used this type transformations.

import Transformation from "../backwards/transformation.js";

Where should i paste this file ?

colbyfayock commented 1 month ago

i think we may be able to import it directly from the dependency, but import it specifically as a type, so that the dependency doesnt impact the bundle size

import type Transformation from ...
nooras commented 1 month ago

@colbyfayock Unable to import Transformation directly in cloudinary-video-player.ts Able to import in url-loader! What should i do? shall i add dependency in type folder ?

image

colbyfayock commented 1 month ago

yeah you can try adding the dependency, npm install @cloudinary/url-gen