If a user is running Netlify CLI local development env (netlify deploy --build) on Windows, generated Cloudinary URLs will contain %5C.
Is this a regression?
Nope!
Steps To Reproduce the error
must be on windows
cd into the root directory of a linked netlify site's repo
Verify that your netlify.toml enables the cloudinary integration and does not specify imagesPath
Build Netlify locally:
netlify deploy --build
Look for section netlify-plugin-cloudinary (onBuild event) in the build logs
Expected behaviour
The redirects should always contain / since they are for a URI, not a file path. In the case of Windows, I would expect the \ which is then escaped to \\ to be replaced with /
CodeSandbox or Live Example of Bug
Check out my branch locally
cd to tests dir
npx vitest
Screenshot or Video Recording
I wrote new tests to confirm the bug
Your environment
OS: Windows 11
Node version: 18
Npm version: 9.8.1
Additional context
I'm trying to do Netlify CLI local development and noticed that the Cloudinary URLs looked wonky. As someone on Windows, I'd like to be able to contribute to this project and make sure the tests run as expected.
Bug Report
Describe the bug
If a user is running Netlify CLI local development env (
netlify deploy --build
) on Windows, generated Cloudinary URLs will contain%5C
.Is this a regression?
Nope!
Steps To Reproduce the error
must be on windows
imagesPath
netlify-plugin-cloudinary (onBuild event)
in the build logsExpected behaviour
The redirects should always contain
/
since they are for a URI, not a file path. In the case of Windows, I would expect the\
which is then escaped to\\
to be replaced with/
CodeSandbox or Live Example of Bug
npx vitest
Screenshot or Video Recording
I wrote new tests to confirm the bug
Your environment
Additional context
I'm trying to do Netlify CLI local development and noticed that the Cloudinary URLs looked wonky. As someone on Windows, I'd like to be able to contribute to this project and make sure the tests run as expected.