Open gshel opened 11 months ago
Name | Link |
---|---|
Latest commit | f8239aec2a880e6d708492c8239d9ada2b5dc452 |
Latest deploy log | https://app.netlify.com/sites/netlify-plugin-cloudinary/deploys/656f89a5d3b8cb000833b8ad |
Deploy Preview | https://deploy-preview-105--netlify-plugin-cloudinary.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Happy to split the unrelated documentation updates into a separate PR if it would make things easier 🎉
thanks @gshel changes look good
im curious to hear about your use case with the crop mode. the reason i hadnt originally allowed that to be configurable was the thought that blanket cropping images across the site would present a challenge for the variety ways an image could be presented, where i was going to eventually allow someone to pass in parameters, such as a URL query params perhaps, to do that programmatically
as far as client hints - what do you think about added the option to allow people to inject the Client Hints meta tag to their site?
perhaps if they pass in an option such as:
clientHints: ["Dpr", "Viewport-Width", "Width"]
we would add the tags:
<meta http-equiv="accept-ch" content="Dpr, Viewport-Width, Width">
<meta http-equiv="delegate-ch" content="sec-ch-width https://res.cloudinary.com; sec-ch-dpr https://res.cloudinary.com; sec-ch-viewport-width https://res.cloudinary.com;">
based on those values
thoughts?
oh, can you also update the documentation website table of configuration options? my intent is to eventually remove them from the README and instead only have them on the documentation site to avoid separate maintenance
it should more or less be the same code that you have already updated, just need to copy and paste i believe
Description
The following changes allow users to follow the suggestions outlined in How to Scale an Image Automatically using Client Hints, specifically:
Changes made:
Issue Ticket Number
Fixes https://github.com/cloudinary-community/netlify-plugin-cloudinary/issues/104
Type of change
Checklist