Get loadingStrategy value from netlify.toml inputs, default to 'lazy' if not provided

gshel commented 1 year ago

Description

loadingStrategy was not being read from the netlify.toml; this PR gets the value from the netlify.toml and if it doesn't exist, it defaults to lazy.

Issue Ticket Number

Fixes https://github.com/cloudinary-community/netlify-plugin-cloudinary/issues/97

Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[X] I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
[X] I have created an issue ticket for this PR
[X] I have checked to ensure there aren't other open Pull Requests for the same update/change?
[X] I have performed a self-review of my own code
[X] I have run tests locally to ensure they all pass
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes needed to the documentation

netlify[bot] commented 1 year ago

Deploy Preview for netlify-plugin-cloudinary ready!

Name	Link
Latest commit	3b94bb8801932b2e8ae292a95ae1b588a2f562d9
Latest deploy log	https://app.netlify.com/sites/netlify-plugin-cloudinary/deploys/65526ef6813f7200081ae618
Deploy Preview	https://deploy-preview-98--netlify-plugin-cloudinary.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

gshel commented 1 year ago

Looks like the tests may need to be updated as well, will continue working on it tomorrow or Monday.

colbyfayock commented 1 year ago

thanks for fixing this 😅 im not sure how i never noticed it not working before, but glad you were able to get it set up working right!

i only really have a question on the context of the posix fix, but it seems like it's to help make the project and tests more reliable from an environment perspective?

colbyfayock commented 1 year ago

great work here @gshel - thank you for the contribution!

colbyfayock commented 1 year ago

@all-contributors please add @gshel for code

allcontributors[bot] commented 1 year ago

@colbyfayock

I've put up a pull request to add @gshel! :tada:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.15.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

colbyfayock commented 1 year ago

FYI 1.15.0 is available on Netlify!

cloudinary-community / netlify-plugin-cloudinary