cloudinary-community / next-cloudinary

⚡️ High-performance image delivery and uploading at scale in Next.js powered by Cloudinary.

https://next.cloudinary.dev

MIT License

257 stars 75 forks source link

[Bug] @ts-ignore in cloudinary-loader.ts #425

Open colbyfayock opened 10 months ago

colbyfayock commented 10 months ago

Bug Report

Describe the bug

A @ts-ignore is currently in place in the cloudinaryLoader function which is what organizes and ultimately helps to build a Cloudinary URL based on Next.js props.

https://github.com/cloudinary-community/next-cloudinary/blob/main/next-cloudinary/src/loaders/cloudinary-loader.ts#L58-L59

Goal wouild be to address whatever type issues are preventing this line from being removed.

RaghavMangla commented 1 month ago

Hi, I'd like to work on this issue

colbyfayock commented 1 month ago

we'll start with the other issue and can work on other issues 1 by 1 unless someone else takes it first. thanks

vickywane commented 1 month ago

Hi @colbyfayock,

I would love to work on this.

I just completed the #541 PR

colbyfayock commented 1 month ago

sure thing!

vickywane commented 1 month ago

@colbyfayock I have sent in a PR for this.

github-actions[bot] commented 3 weeks ago

:tada: This issue has been resolved in version 7.0.0-beta.10 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

vickywane commented 1 week ago

@colbyfayock I think we can close this.