cloudinary-community / next-cloudinary

⚡️ High-performance image delivery and uploading at scale in Next.js powered by Cloudinary.
https://next.cloudinary.dev
MIT License
237 stars 64 forks source link

[Bug] quality="auto" or quality="auto:eco" return typescript error #449

Closed zecka closed 4 months ago

zecka commented 4 months ago

Bug Report

Describe the bug

Quality in cloudinary seems to allow "auto" or "auto:eco": https://cloudinary.com/blog/the_holy_grail_of_image_optimization_or_balancing_visual_quality_and_file_size#automatic_image_quality_8211_q_auto

If we passe auto to the component we got a typescript errror

image

Is this a regression?

This is not a regression

Your environment

github-actions[bot] commented 4 months ago

:tada: This issue has been resolved in version 6.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

colbyfayock commented 4 months ago

thanks for flagging @zecka - just a heads up, the default value for the component is auto but auto:eco should certainly be supported as well!

zecka commented 4 months ago

Thank's @colbyfayock, i updated to 6.1.1 but I stil have the issue

image

I think now it's a conflict with next/image props definition image

colbyfayock commented 4 months ago

ah, i swear i tested it and didnt see any issues, but perhaps i only tested in the core library definition

thanks for the PR, reviewing

github-actions[bot] commented 4 months ago

:tada: This issue has been resolved in version 6.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: