cloudinary-community / svelte-cloudinary

⚡️ High-performance image delivery and uploading at scale in Svelte powered by Cloudinary.
https://svelte.cloudinary.dev/
MIT License
24 stars 11 forks source link

[Bug] Fix CldVideoPlayer aspect ratio jump on load #106

Closed colbyfayock closed 2 months ago

colbyfayock commented 2 months ago

When the CldVideoPlayer loads, the initial player size may be different from the videos if it is not 16:9, which is in the case at a minimum for some of the demo videos we use.

To fix this, we can define a width, height, and aspectRatio on the player initialization config:

        width,
        height,
        aspectRatio: `${width}:${height}`,

Which can be taken straight from the props.

https://github.com/cloudinary-community/next-cloudinary/pull/461/files#diff-a55bcf836522ca3b2611e1c71bf0dd0ac5ea8a13832d57f433ac9bd75f487515R168

When updating this, you'll need to update the @cloudinary-util/types package to at least 1.0.2 to pull in i think just the aspectRatio.