cloudinary-community / svelte-cloudinary

⚡️ High-performance image delivery and uploading at scale in Svelte powered by Cloudinary.
https://svelte.cloudinary.dev/
MIT License
28 stars 14 forks source link

fix: Validation for cloud name #63

Closed HeetVekariya closed 11 months ago

HeetVekariya commented 11 months ago

Description

Closes #58

Changes made


Issue Ticket Number

Fixes #58

Type of change

Checklist

vercel[bot] commented 11 months ago

@HeetVekariya is attempting to deploy a commit to the Cloudinary DevX Team on Vercel.

A member of the Team first needs to authorize it.

colbyfayock commented 11 months ago

hey @matiasfha we had some chatter in the Space Jelly discord in the #development channel if you want to get a bit of context here, have some thoughts id love to get your input on

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-cloudinary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 7:15pm
matiasfha commented 11 months ago

Looks great!. I liked the approach. the CldImage and CldOgImage component also requires this validation. This can be added into the component itself or here

HeetVekariya commented 11 months ago

@matiasfha Thank you for your comment, as suggested the changes are implemented.

HeetVekariya commented 11 months ago

Also please double check my imports, may it can be wrong

matiasfha commented 11 months ago

Works great! Thanks for your work and the PR

matiasfha commented 11 months ago

@all-contributors please add @HeetVekariya for code

allcontributors[bot] commented 11 months ago

@matiasfha

I've put up a pull request to add @HeetVekariya! :tada:

github-actions[bot] commented 11 months ago

:tada: This PR is included in version 1.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

colbyfayock commented 11 months ago

@HeetVekariya congrats on the merged PR! since it's officially October, you've always qualified for Hacktoberfest swag! please email hacktoberfest@cloudinary.com with your github username and a link to your contribution where I'll follow up to request more information for getting you your swag

https://cloudinary.com/blog/hacktoberfest-celebrate-open-source-sdks