Closed HeetVekariya closed 11 months ago
@HeetVekariya is attempting to deploy a commit to the Cloudinary DevX Team on Vercel.
A member of the Team first needs to authorize it.
hey @matiasfha we had some chatter in the Space Jelly discord in the #development channel if you want to get a bit of context here, have some thoughts id love to get your input on
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
svelte-cloudinary | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 12, 2023 7:15pm |
Looks great!. I liked the approach. the CldImage and CldOgImage component also requires this validation. This can be added into the component itself or here
@matiasfha Thank you for your comment, as suggested the changes are implemented.
Also please double check my imports, may it can be wrong
Works great! Thanks for your work and the PR
@all-contributors please add @HeetVekariya for code
@matiasfha
I've put up a pull request to add @HeetVekariya! :tada:
:tada: This PR is included in version 1.1.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
@HeetVekariya congrats on the merged PR! since it's officially October, you've always qualified for Hacktoberfest swag! please email hacktoberfest@cloudinary.com with your github username and a link to your contribution where I'll follow up to request more information for getting you your swag
https://cloudinary.com/blog/hacktoberfest-celebrate-open-source-sdks
Description
Closes #58
VITE_PUBLIC_CLOUDINARY_CLOUD_NAME
Changes made
Added a custom function
checkCloudinaryCloudName
in thecloudinary.ts
, which accepts the cloud name as a parameter and throws error if it is nullImported that function in the below files and passed environment variable as a parameter:
Note : When i run
pnpm install
it gives me error, so i am not able to test it locallyIssue Ticket Number
Fixes #58
Type of change
Checklist