cloudinary-community / svelte-cloudinary

⚡️ High-performance image delivery and uploading at scale in Svelte powered by Cloudinary.

https://svelte.cloudinary.dev/

MIT License

24 stars 11 forks source link

[Bug] Revert ENV changes to avoid Svelte vs SvelteKit conflict #91

Closed colbyfayock closed 3 months ago

colbyfayock commented 4 months ago

Bug Report

Describe the bug

A change was made to try to provide support for both Svelte and SvelteKit ENV naming patterns:

https://github.com/cloudinary-community/svelte-cloudinary/pull/82 https://github.com/cloudinary-community/svelte-cloudinary/pull/90

But it sounds like this breaks traditional Svelte usage as the import of $env/dynamic/public for SvelteKit is not available and breaks.

Nearterm solution should be to revert these changes as a minor release and moving forward, come up with a more comprehensive solution for the next or a future major release

MapleThunder commented 4 months ago

Is there a work around to be able to build static sites as right now I can't. Is the only solution to revert to an earlier version of the package ?

colbyfayock commented 3 months ago

@MapleThunder working to get it addressed ASAP, but for now that would likely be the safest bet as I unfortunately don't have an exact timeline

can you share the issue that you're running into so we can make sure it's covered? is it simply that you're running a traditional Svelte site and it's not building?

github-actions[bot] commented 3 months ago

:tada: This issue has been resolved in version 1.2.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

colbyfayock commented 3 months ago

@MapleThunder nm my last message :) if you want to try 1.2.4, hopefully that addresses your issue