Closed const-cloudinary closed 11 months ago
@const-cloudinary
Where should the tests be added for this if the playback_url
field is empty?
@const-cloudinary Can u assign this to me please?
@Suraj3240 are you already working on this?
@Suraj3240 are you already working on this?
I have added the playbackurl
field.
I wanted to know where to add the ckeck for empty playbackurl thing?
@const-cloudinary should be able to answer that within the next few days (it's the weekend) but making sure someone else didn't start working on it if you were already :)
So will it be assigned to me or to @AnshShah77 ?
you said you were already working on it, so you! :) we just ask for a little patience for the assignment and for someone from the SDK team (not me) to respond to your question above. thanks
Ok great :) Thanks Sorry @AnshShah77 🙈 @colbyfayock Ansh is my friend only :))
np @Suraj3240 , all the best!!
@Suraj3240 Regarding your question, this field should not be empty for any video. Having said that, if the field is empty - it should not be a problem, it will be left as an empty string. Adding a test where playback url is not empty should be sufficient.
So in which file should I add a test for this?
@Suraj3240 this looks like a good candidate: https://github.com/cloudinary/CloudinaryDotNet/blob/a3df716e77aa81db98aea61002f3b881d6a7de9a/CloudinaryDotNet.IntegrationTests/UploadApi/UploadMethodsTest.cs#L203
Feature request for Cloudinary .NET SDK
When uploading a video file the result contains
playback_url
field which is currently not exposed in Cloudinary .NET SDK.Do you have a proposed solution?
Add
PlaybackUrl
field in VideoUploadResult