Currently, for download_files, we only sign URLs if the type is private/authenticated but any assets already uploaded with access_mode: authenticated can't be downloaded without a valid signed URL. Adding change to also sign if the asset in question has access mode set. Otherwise, Sync Pull actions will fail for such assets.
Via the CLI, Access Mode isn't supported to be set (such as via the upload() method of Upload API) nor does it contain update_access_mode_* methods as part of the Admin API though for Sync purposes I think it makes sense to be able to download previously uploaded assets with access_mode.
What does this PR address?
[ ] GitHub issue (Add reference - #XX)
[ ] Refactoring
[X] New feature
[ ] Bug fix
[ ] Adds more tests
Are tests included?
[ ] Yes
[X] No
Reviewer, please note:
Checklist:
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[X] I ran the full test suite before pushing the changes and all the tests pass.
Brief Summary of Changes
Currently, for
download_files, we only sign URLs if thetypeisprivate/authenticatedbut any assets already uploaded withaccess_mode: authenticatedcan't be downloaded without a valid signed URL. Adding change to also sign if the asset in question has access mode set. Otherwise, Sync Pull actions will fail for such assets.Via the CLI, Access Mode isn't supported to be set (such as via the upload() method of Upload API) nor does it contain
update_access_mode_*methods as part of the Admin API though for Sync purposes I think it makes sense to be able to download previously uploaded assets with access_mode.What does this PR address?
Are tests included?
Reviewer, please note:
Checklist: