cloudinary / cloudinary-cli

A command line interface for Cloudinary's APIs
https://cloudinary.com/documentation/cloudinary_cli
MIT License
17 stars 9 forks source link

Dockerfile improvements #98

Closed pataquets closed 1 month ago

pataquets commented 1 month ago

Brief Summary of Changes

What does this PR address?

Are tests included?

Reviewer, please note:

Follow-up of #96. Notice that current Dockerfile is not a source build, but a download-from-pypi-and-install build, and it is not pinned to any version. It'll suffice for a "Just Build :tm:" from repo one liner to hit the road ASAP:

$ # Build image straight from source Github repo URL (no clone needed)
$ docker build -t cloudinary https://github.com/cloudinary/cloudinary-cli.git#main
$ # Profit!
$ docker run --rm -it cloudinary config

But it won't work for local development workflow.

Checklist:

const-cloudinary commented 1 month ago

@pataquets those are great improvements!

Thank you for contribution!

colbyfayock commented 1 month ago

@pataquets thanks for your contribution. this PR is eligible for free Cloudinary Hackatoberfest swag. Please send me an email at hacktoberfest@cloudinary.com with your name, GitHub username, and a link to the PR where I'll send further instructions.

Happy Hacktoberfest!