search

cloudinary / cloudinary-video-player

Cloudinary Video Player
MIT License
70 stars 24 forks source link

Me 18059 esm tests over preview build #719

Closed ShayLevi closed 2 weeks ago

ShayLevi commented 2 weeks ago

Currently ESM tests were running against const link const ESM_URL = 'https://cld-vp-esm-pages.netlify.app/';

The change is to run on the deploy preview build instead of the one from edge. Local tests (if needed to run from the branch) will be executed against latest EDGE (https://cld-vp-esm-pages.netlify.app/) Also added waitFor function to check if deploy URL is ready

netlify[bot] commented 2 weeks ago

Deploy Preview for cld-video-player ready!

Name Link
Latest commit c163e382705c4062a900d1f87b9128d491d92188
Latest deploy log https://app.netlify.com/sites/cld-video-player/deploys/6720d52c31bcda0008f1ec17
Deploy Preview https://deploy-preview-719--cld-video-player.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for cld-vp-esm-pages ready!

Name Link
Latest commit 47e85adb3ede263fa70fd8e233562c4f5edc94e6
Latest deploy log https://app.netlify.com/sites/cld-vp-esm-pages/deploys/67222ac6c55c6100086d37a9
Deploy Preview https://deploy-preview-719--cld-vp-esm-pages.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.