cloudinary / cloudinary_java

Cloudinary Java Client Library
MIT License
163 stars 110 forks source link

Hide constructors of utility classes #340

Open vil02 opened 2 weeks ago

vil02 commented 2 weeks ago

Bug report for Cloudinary Java SDK

Before proceeding, please update to latest version and test if the issue persists

Describe the bug in a sentence or two.

These classes:

are utilities and their constructors should be hidden and they should be marked as final. Such change makes it harder to misuse them (prevents instantiation and inheritance) and makes the coverage reports more accurate.

Issue Type (Can be multiple)

[ ] Build - Can’t install or import the SDK [ ] Performance - Performance issues [ ] Behaviour - Functions aren’t working as expected (Such as generate URL) [ ] Documentation - Inconsistency between the docs and behaviour [x] Other (Specify) - code quality

Related to #337.

s-vamshi commented 1 week ago

Hey @vil02 , i would like to work on this issue can you please assign this to me?

vil02 commented 1 week ago

Hi @s-vamshi,

I am not a maintainer of this repository. I by creating this issue I explicitly expressed my interest in being assigned to it. Please have a look at: DO NOT submit a PR without an active Issue that has been approved..

@colbyfayock, @adimiz1, @const-cloudinary: could you please have a look?

vil02 commented 1 week ago

So... could I create a pull request fixing this?

michal-sordyl-cloudinary commented 1 week ago

@vil02 yes, please create PR

RaghavMangla commented 1 week ago

Hi! which among these issues, are hacktoberfest accepted