Open vil02 opened 1 week ago
@adimiz1, @michal-sordyl-cloudinary, @colbyfayock: is there anything else what I should do regarding this pull request?
thanks @vil02 for the PR. This will be reviewed by the relevant SDK team member.
While this will count towards hacktoberfest.com as the label is on the repository, just wanted to clarify that this will not count towards Cloudinary's Hacktoberfest swag based on the rules provided here: https://cld.media/hacktoberfest
we appreciate your contribution to improving the code health of the project!
just wanted to clarify that this will not count towards Cloudinary's Hacktoberfest swag based on the rules provided here: https://cld.media/hacktoberfest
@colbyfayock: could you please elaborate more on that? I thought that https://github.com/cloudinary/cloudinary_java/issues/340#issuecomment-2396442865 counts as an approval.
i think the confusion is that the person who was giving you the go ahead was just simply saying you could put together a PR when you asked:
So... could I create a pull request fixing this?
but because i could see how that could be confusing we'll just let it count towards the swag pack if it's approved and merged
@colbyfayock: thanks! That is nice of you. Let's hope this will be merged in time.
Brief Summary of Changes
All changed classes are now marked as
final
and their default constructor asprivate
(i.e. it is hidden).What does this PR address?
Are tests included?
Reviewer, please note:
Fixes #340.
Checklist: