search

cloudinary / cloudinary_js

Cloudinary JavaScript library
MIT License
328 stars 224 forks source link

Lazy-loading support with lazysizes (https://github.com/aFarkas/lazysizes) #205

Closed yuval-cloudinary closed 4 years ago

yuval-cloudinary commented 4 years ago

Based on a work done for Swarovski

patrick-tolosa commented 4 years ago

Thanks for the PR,

Unfortunately, this PR currently conflicts with changes in master, more specifically it conflicts with the newly implemented solution for lazy loading.

Do you suggest we use this solution instead of the current implementation? if so, could you explain what our current implementation doesn't cover?

before adding a dependency we'd like to make sure there's a good case for it.

yuval-cloudinary commented 4 years ago

@patrick-tolosa At the time I've published my PR, there was no lazy loading support at all in this package. Looking at the newly merged implementation, I agree that both changes should not coincide.

Please notice that you should add the lazy loading to the JQuery plugin and the bundle, similar to this PR. Also, some documentation and author recognition should be added to the README