Fix `e_preview` normalization - Githubissues

cloudinary / cloudinary_kotlin

Cloudinary Kotlin SDK library

MIT License

11 stars 4 forks source link

Fix `e_preview` normalization #43

Closed adimiz1 closed 2 years ago

adimiz1 commented 2 years ago

Brief Summary of Changes

Root Cause

Normalize function for expression changed variables such as: duration

Implementation

The :${it} part is to prevent normalization of vars with a preceding colon (such as :duration)

What does this PR address?

[ ] GitHub issue (Add reference - #XX)
[ ] Refactoring
[ ] New feature
[x] Bug fix
[ ] Adds more tests

Are tests included?

[x] Yes
[ ] No

Reviewer, please note:

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I ran the full test suite before pushing the changes and all the tests pass.

adimiz1 commented 2 years ago

@patrick-tolosa regarding the link you attached it answered another problem needs to be solved, where variable names using $ are getting normlized , but that's a different PR , I agree we should add all those test cases.