cloudinary / cloudinary_magento2

Cloudinary's Magento 2 extension. Upload product images to the cloud, manipulate them to match your graphic design and optimize images for better user experience
MIT License
15 stars 8 forks source link

update to 1.14.6 downgrades cloudinary/cloudinary_php #83

Closed donblackowiak closed 3 years ago

donblackowiak commented 3 years ago

php -d memory_limit=5G composer.phar require cloudinary/cloudinary_php:^1.14.6 cloudinary/cloudinary-magento2 Using version ^1.14 for cloudinary/cloudinary-magento2 ./composer.json has been updated Running composer update cloudinary/cloudinary_php cloudinary/cloudinary-magento2 Loading composer repositories with package information In Laminas\DependencyPlugin\DependencyRewriterV2::onPrePoolCreate Updating dependencies Lock file operations: 0 installs, 2 updates, 2 removals

igy commented 3 years ago

Hi Don,

We recently upgraded our PHP SDK to a v2.x version, and that's a backwards-incompatible change.

The dependencies of this plugin didn't require a specific versions of cloudinary_php so users adding the plugin were unintentionally getting an incompatible version installed after the 2.x versions became available. That was corrected in 1.14.6 so that the plugin installs the newest 1.x version, which it's compatible with.

If our plugin is updated to work with the newer Cloudinary PHP SDK we'll update the dependency again in the appropriate version.

I'm not aware of any associated intentional change regarding teapot/status-code or shrikeh/teapot that are also shown in your output, but if that caused you any problems, may I please ask for some more information about the issue and I can check it for you?

Regards, Stephen

donblackowiak commented 3 years ago

Hi Stephen

Glad to hear it was intentional. This was all part of a Magento 2.4.2 upgrade test which failed, so I will try again in a couple weeks after all the vendors have worked out their kinks.

--Don

Don Blackowiak

don@lucuma.com

Cofounder, Lucuma Designs, LLC

www.Lucuma.com - 877-858-2862 - Fax 877-363-0735

proud members of the Fair Trade Federation & 1% for the Planet

From: Stephen notifications@github.com Reply-To: cloudinary/cloudinary_magento2 reply@reply.github.com Date: Friday, February 12, 2021 at 7:27 AM To: cloudinary/cloudinary_magento2 cloudinary_magento2@noreply.github.com Cc: "don@lucuma.com" don@lucuma.com, Author author@noreply.github.com Subject: Re: [cloudinary/cloudinary_magento2] update to 1.14.6 downgrades cloudinary/cloudinary_php (#83)

Hi Don,

We recently upgraded our PHP SDK to a v2.x version, and that's a backwards-incompatible change.

The dependencies of this plugin incorrectly specified no specific versions of cloudinary_php so users adding the plugin were getting an incompatible version installed. That was corrected in 1.14.6 so that the plugin installs the newest 1.x version.

If our plugin is updated to work with the newer Cloudinary PHP SDK we'll update the dependency again in the appropriate version.

I'm not aware of any associated intentional change regarding teapot/status-code or shrikeh/teapot that are also shown in your output, but if that caused you any problems, may I please ask for some more information about the issue and I can check it for you?

Regards, Stephen

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

igy commented 3 years ago

Hi Don,

From our side, it should be OK if you're using cloudinary-magento2 1.14.6

I'll close this issue for now, but please do let us know if you encounter any other issues, and apologies for any confusion caused by the versions changing.

Regards, Stephen