search

cloudinary / cloudinary_magento2

Cloudinary's Magento 2 extension. Upload product images to the cloud, manipulate them to match your graphic design and optimize images for better user experience
MIT License
15 stars 8 forks source link

Fix `Fallback to JQueryUI Compat activated`. #95

Closed frqnck closed 2 years ago

frqnck commented 3 years ago

This short PR fixes:

Fallback to JQueryUI Compat activated. Your store is missing a dependency for a jQueryUI widget. Identifying and addressing the dependency will drastically improve the performance of your site. Compat.js

jquery/ui is deprecated since Magento 2.3 and has been split into dedicated modules to improve performance.

frqnck commented 2 years ago

This PR has being incubating here since May 2021?

When will this be merged? Doing so "will drastically improve the performance" of this module on the PDPs (Product Detail Pages) of your customers...

We are patching your code our end but would appreciate not having to have to do this.

wissam-khalili commented 2 years ago

This PR should be merged in our next version.

wissam-khalili commented 2 years ago

Hi @frqnck ,

Have you tried to upgrade to our latest version #112 ?

Regards, Wissam

frqnck commented 1 year ago

I can see you have now merged this although you seems to have close this PR and added the change manually so we did not notice the addition until now. We will upgrade accordingly. Thanks you.

wissam-khalili commented 1 year ago

Hi @frqnck ,

I thought I have sent you a notification about the fixed version. Sorry for the inconvenience. Please upgrade to the latest version and let me know how it goes,

Regards, Wissam