cloudinary / cloudinary_npm

Cloudinary NPM for node.js integration
629 stars 323 forks source link

fix: remove dependency on Q #666

Open talentlessguy opened 5 months ago

talentlessguy commented 5 months ago

Brief Summary of Changes

This PR removes a deprecated and outdated Promise library - Q. And replaces it with Promise API and built-ins.

deprecation notice from q:

You or someone you depend on is using Q, the JavaScript Promise library that gave JavaScript developers strong feelings about promises. They can almost certainly migrate to the native JavaScript promise now. Thank you literally everyone for joining me in this bet against the odds. Be excellent to each other. (For a CapTP with native promises, see @endo/eventual-send and @endo/captp)

The source now uses the following methods:

What Does This PR Address?

Are Tests Included?

cloudinary-pkoniu commented 4 months ago

@talentlessguy PR looks great, thank you for your contribution. Can you please pull latest master? There are some fixes to the CI that need to be included before we can merge.

talentlessguy commented 4 months ago

@cloudinary-pkoniu sure thing