Sni 6834 vue advanced video

cloudinary / frontend-frameworks

Cloudinary javascript frontend frameworks SDKs, including Shared HTML layer, Angular, React and Vue SDKs

https://www.cloudinary.com

MIT License

44 stars 15 forks source link

Sni 6834 vue advanced video #191

Closed pawelphilipczyk-cloudinary closed 1 year ago

pawelphilipczyk-cloudinary commented 1 year ago

Pull request for cloudinary/frontend-frameworks

For which package is this PR?

@cloudinary/vue

What does this PR solve?

Adds missing video component to vue sdk

Relates to

https://cloudinary.atlassian.net/browse/SNI-6834

Final checklist

[x] Implementation is aligned to Spec.
[x] Tests - Add proper tests to the added code.
[x] Relates to a Jira issue (link to issue).

patrick-tolosa commented 1 year ago

Looks good, tests and implementation wise!

It might be worth checking what types of plugins are we supporting with this element, since not all plugins would/should work IIRC.

From experience, listing them in advance can save time in debugging future issues.

pawelphilipczyk-cloudinary commented 1 year ago

Thanks for taking the time to review this @patrick-tolosa !

Regarding listing the plugins I guess we can take a look at this when work on docs starts. Code wise it's now the same exact Plugins type as React video component is using so we have parity on that level.