fix: pass analytics options down to the plugins, and use it in placeh…

cloudinary / frontend-frameworks

Cloudinary javascript frontend frameworks SDKs, including Shared HTML layer, Angular, React and Vue SDKs

https://www.cloudinary.com

MIT License

42 stars 16 forks source link

fix: pass analytics options down to the plugins, and use it in placeh… #196

Closed lbendavid-cloudinary closed 1 year ago

lbendavid-cloudinary commented 1 year ago

…older & responsive

Pull request for cloudinary/frontend-frameworks

For which package is this PR?

@cloudinary/html

What does this PR solve?

Currently responsive and placeholder creates Url's without analytics. The change is to pass the analytics options from HTMLImageLayer to the plugins.

Final checklist

[x] Implementation is aligned to Spec.
[ ] Tests - Add proper tests to the added code.
[ ] Relates to a github issue (link to issue).

const-cloudinary commented 1 year ago

@lbendavid-cloudinary where do we set the feature codes (for responsive and placeholder)?

lbendavid-cloudinary commented 1 year ago

@lbendavid-cloudinary where do we set the feature codes (for responsive and placeholder)?

@const-cloudinary feature codes was never implemented in this project. We may consider implementing them

lbendavid-cloudinary commented 1 year ago

@pawelphilipczyk-cloudinary yes, but it should be done in a separate effort since it require some infra changes and it is out of this feature's scope