cloudinary / php-transformation-builder-sdk

Cloudinary PHP Transformation Builder SDK
https://cloudinary.com/documentation/php_image_manipulation
MIT License
3 stars 4 forks source link

Incorrect PHPDoc @param object types #4

Open magnusnordlander opened 1 year ago

magnusnordlander commented 1 year ago

Bug report for Cloudinary PHP Transformation Builder SDK

Before proceeding, please update to the latest version and test if the issue persists

Describe the bug in a sentence or two.

Incorrect PHPDoc tag for Cloudinary\Transformation\TransformationResizeTrait::fill. The $gravity argument is documented as taking an instance of Cloudinary\Transformation\Gravity, but in fact expects an instance of Cloudinary\Transformation\GravityQualifier. Presumably this is a bigger issue than just this one argument, but this is where PHPStan complains for me, so I thought I'd start somewhere.

Issue Type (Can be multiple)

wissam-khalili commented 1 year ago

Hi @magnusnordlander ,

Thank you for your feedback. I will check the issue internally and keep you posted on our findings.

Regards, Wissam